Updating and re-opening PR #48129 #50541
Conversation
Co-authored-by: Matthew Roeschke <[email protected]>
gfyoung
added
Bug
Datetime
| @@ -761,7 +761,10 @@ def _add_offset(self, offset) -> DatetimeArray: | |||
| assert not isinstance(offset, Tick) | |||
|
|
|||
| if self.tz is not None: | |||
| values = self.tz_localize(None) | |||
| if not offset._use_relativedelta: | |||
There was a problem hiding this comment.
is there a viable way to handle this inside the Offset code? in theory the DTA code shouldn't need to know anything about _use_relativedelta
There was a problem hiding this comment.
The issue is with how these dates are localized, and I don't believe there is a good way to modify this in the Offset code.
| ] | ||
| ) | ||
| offset1 = DateOffset(hours=3) | ||
| offset2 = DateOffset(days=1) |
There was a problem hiding this comment.
looks like this only tests the DateOffset class, for which _use_relativedelta can be True. but the code you changed affects a bunch of other classes
There was a problem hiding this comment.
Alright, I'll try and work on some tests for the other classes.
|
This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this. |
|
Sorry this went stale, I've been really busy lately, I think I'll be able to find time to clean this up soon. |
|
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen. |
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.